Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Retention Tab #3783

Merged
merged 2 commits into from
Jan 5, 2022
Merged

Adding Retention Tab #3783

merged 2 commits into from
Jan 5, 2022

Conversation

samikroy
Copy link
Contributor

Adding retention tab to incorporate with export to excel option.

Proposed Changes

  1. Display Workspace level retention.
  2. Display Table level retention.
  3. Both contains Export to excel functionality.

@samikroy
Adding Retention Tab
3973932 
Adding retention tab to incorporate with export to excel option.

1. Display Workspace level retention.
2. Display Table level retention.
@v-jayakal v-jayakal self-assigned this Dec 28, 2021
@v-sabiraj
Copy link
Contributor

Please add preview images, thanks.

@samikroy
Copy link
Contributor Author

Please add preview images, thanks.

@v-sabiraj - Thank you.

image

image

These are the images.

As this is 2.0 > 2.1 version upgrade do you suggest to add these previews to workbook preview images ?

@shainw shainw added the Workbook Workbook specialty review needed label Jan 3, 2022
NikTripathi
NikTripathi approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@NikTripathi NikTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workbook looks good.

@NikTripathi NikTripathi merged commit 2eef8a5 into Azure:master Jan 5, 2022
@samikroy samikroy deleted the patch-12 branch January 5, 2022 20:12
@samikroy
Copy link
Contributor Author

samikroy commented Jan 5, 2022

Workbook looks good.

Thank you @NikTripathi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikTripathi NikTripathi NikTripathi approved these changes

@liatlishams liatlishams Awaiting requested review from liatlishams

Assignees

@v-jayakal v-jayakal

Labels
Workbook Workbook specialty review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@samikroy @v-sabiraj @NikTripathi @shainw @v-jayakal